Extract DeviceType to a standalone header file #11145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertfire
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11145
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 48989fc with merge base 0cf2d53 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75313723 |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
facebook-github-bot
pushed a commit
that referenced
this pull request
May 27, 2025
Summary: X-link: pytorch/pytorch#154417 The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does: * Extract the DeviceType enum class into a standalone header file in a new torch/standalone/header_only directory * Retain the existing c10/core/DeviceType.[h|cpp] files to handle complex logic and static variables * Import symbols from the new torch::standalone namespace into c10 for backward compatibility This is an updated version of pytorch/pytorch#152787, because we need to land in fbcode first. See the original comments and discussions in pytorch/pytorch#152787. Reviewed By: janeyx99 Differential Revision: D75313723
facebook-github-bot
force-pushed
the
export-D75313723
branch
from
2a2bb38 to
0b5d9d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75313723 |
Summary: X-link: pytorch/pytorch#154417 The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does: * Extract the DeviceType enum class into a standalone header file in a new torch/standalone/header_only directory * Retain the existing c10/core/DeviceType.[h|cpp] files to handle complex logic and static variables * Import symbols from the new torch::standalone namespace into c10 for backward compatibility This is an updated version of pytorch/pytorch#152787, because we need to land in fbcode first. See the original comments and discussions in pytorch/pytorch#152787. Reviewed By: janeyx99 Differential Revision: D75313723
facebook-github-bot
force-pushed
the
export-D75313723
branch
from
0b5d9d4 to
48989fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75313723 |
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
May 27, 2025
Summary: X-link: pytorch/executorch#11145 The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does: * Extract the DeviceType enum class into a standalone header file in a new torch/standalone/header_only directory * Retain the existing c10/core/DeviceType.[h|cpp] files to handle complex logic and static variables * Import symbols from the new torch::standalone namespace into c10 for backward compatibility This is an updated version of #152787, because we need to land in fbcode first. See the original comments and discussions in #152787. Test Plan: CI Reviewed By: janeyx99 Differential Revision: D75313723
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
May 27, 2025
Summary: X-link: pytorch/executorch#11145 Pull Request resolved: #154417 The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does: * Extract the DeviceType enum class into a standalone header file in a new torch/standalone/header_only directory * Retain the existing c10/core/DeviceType.[h|cpp] files to handle complex logic and static variables * Import symbols from the new torch::standalone namespace into c10 for backward compatibility This is an updated version of #152787, because we need to land in fbcode first. See the original comments and discussions in #152787. Test Plan: CI Reviewed By: janeyx99 Differential Revision: D75313723
|
This pull request has been reverted by 01d6441. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/pytorch#154417
The goal of this PR and future follow-up PRs is to group a set of header files required by AOTInductor Standalone in a separate directory, ensuring they are implemented in a header-only manner. More specifically, here is what this PR does:
This is an updated version of pytorch/pytorch#152787, because we need to land in fbcode first. See the original comments and discussions in pytorch/pytorch#152787.
Differential Revision: D75313723