Arm backend: Fix decompose_meandim_pass bug #11141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this pass could insert avg_pool ops with configurations not supported for Ethos-U55. Check this using the AvgPool2dSupported checker and decompose fully using sum for non supported cases. Also modifies the test cases to test this, +more varied shapes. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I6ee6e4b7a4d92f41c2598e53eb614097d04b3d40
AdrianLundell
added
ciflow/trunk
topic: not user facing
module: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11141
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 57ce9c8 with merge base aaf0ecc ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
May 27, 2025
|
non Arm unitests fails are unrelated and fails on main also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this pass could insert avg_pool ops with configurations not supported for Ethos-U55. Check this using the AvgPool2dSupported checker and decompose fully using sum for non supported cases.
Also modifies the test cases to test this, +more varied shapes.