[ET-VK] De vectorise positions in conv2d pw shader to improve perf. #11122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the performance of the conv2d pw shader by fully de-vectorizing it. The optimization involved replacing the `ivec3 pos` array with a plain `int pos` array to store the position values. The `x` and `y` coordinates are now stored in separate elements of the array instead of being stored together in an `ivec3`. This change allows for more efficient memory access and computation. Differential Revision: [D75335802](https://our.internmc.facebook.com/intern/diff/D75335802/) [ghstack-poisoned]
This was referenced May 23, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11122
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 305d686 with merge base 380eb5f ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
trivedivivek
added a commit
that referenced
this pull request
May 24, 2025
This improves the performance of the conv2d pw shader by fully de-vectorizing it. The optimization involved replacing the `ivec3 pos` array with a plain `int pos` array to store the position values. The `x` and `y` coordinates are now stored in separate elements of the array instead of being stored together in an `ivec3`. This change allows for more efficient memory access and computation. Differential Revision: [D75335802](https://our.internmc.facebook.com/intern/diff/D75335802/) ghstack-source-id: 286016142 Pull Request resolved: #11122
|
This pull request was exported from Phabricator. Differential Revision: D75335802 |
This improves the performance of the conv2d pw shader by fully de-vectorizing it. The optimization involved replacing the `ivec3 pos` array with a plain `int pos` array to store the position values. The `x` and `y` coordinates are now stored in separate elements of the array instead of being stored together in an `ivec3`. This change allows for more efficient memory access and computation. Differential Revision: [D75335802](https://our.internmc.facebook.com/intern/diff/D75335802/) [ghstack-poisoned]
This was referenced May 27, 2025
|
This pull request was exported from Phabricator. Differential Revision: D75335802 |
This improves the performance of the conv2d pw shader by fully de-vectorizing it. The optimization involved replacing the `ivec3 pos` array with a plain `int pos` array to store the position values. The `x` and `y` coordinates are now stored in separate elements of the array instead of being stored together in an `ivec3`. This change allows for more efficient memory access and computation. Differential Revision: [D75335802](https://our.internmc.facebook.com/intern/diff/D75335802/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75335802 |
SS-JIA
approved these changes
May 27, 2025
This improves the performance of the conv2d pw shader by fully de-vectorizing it. The optimization involved replacing the `ivec3 pos` array with a plain `int pos` array to store the position values. The `x` and `y` coordinates are now stored in separate elements of the array instead of being stored together in an `ivec3`. This change allows for more efficient memory access and computation. Differential Revision: [D75335802](https://our.internmc.facebook.com/intern/diff/D75335802/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75335802 |
trivedivivek
added
the
release notes: none
This improves the performance of the conv2d pw shader by fully de-vectorizing it. The optimization involved replacing the `ivec3 pos` array with a plain `int pos` array to store the position values. The `x` and `y` coordinates are now stored in separate elements of the array instead of being stored together in an `ivec3`. This change allows for more efficient memory access and computation. Differential Revision: [D75335802](https://our.internmc.facebook.com/intern/diff/D75335802/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75335802 |
This improves the performance of the conv2d pw shader by fully de-vectorizing it. The optimization involved replacing the `ivec3 pos` array with a plain `int pos` array to store the position values. The `x` and `y` coordinates are now stored in separate elements of the array instead of being stored together in an `ivec3`. This change allows for more efficient memory access and computation. Differential Revision: [D75335802](https://our.internmc.facebook.com/intern/diff/D75335802/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75335802 |
This improves the performance of the conv2d pw shader by fully de-vectorizing it. The optimization involved replacing the `ivec3 pos` array with a plain `int pos` array to store the position values. The `x` and `y` coordinates are now stored in separate elements of the array instead of being stored together in an `ivec3`. This change allows for more efficient memory access and computation. Differential Revision: [D75335802](https://our.internmc.facebook.com/intern/diff/D75335802/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75335802 |
facebook-github-bot
merged commit 709ca10
into
gh/trivedivivek/93/base
96 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
changed the title
trivedivivek
added a commit
that referenced
this pull request
May 28, 2025
…11186) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11122 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/93/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/93/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/92/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/93/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This improves the performance of the conv2d pw shader by fully de-vectorizing it.
The optimization involved replacing the
ivec3 posarray with a plainint posarray to store the position values. Thexandycoordinates are now stored in separate elements of the array instead of being stored together in anivec3. This change allows for more efficient memory access and computation.Differential Revision: D75335802