Skip to content

Fix triu/tril CoreML lowering error in to_edge_transform_and_lower #11107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025

Conversation

metascroy
Copy link
Contributor

@metascroy metascroy commented May 23, 2025

This PR fixes a CoreML lowering issue with triu/tril when using to_edge_transform_and_lower.

It also changes the warning logging in _remove_invalid_ops_for_not_decompose to log only once per call, rather than once per op.

Copy link

pytorch-bot bot commented May 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11107

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 13beffa with merge base 18e5eca (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2025
@metascroy metascroy added the release notes: none Do not include this in the release notes label May 23, 2025
@metascroy metascroy requested a review from YifanShenSZ May 23, 2025 19:42
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@metascroy metascroy merged commit 22e7dbd into main May 28, 2025
100 of 103 checks passed
@metascroy metascroy deleted the coreml-op-skip branch May 28, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants