Skip to content

Dtype selective build: disable when not in xplat and add fail msg #11090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh/lucylq/84/base
Choose a base branch
from
Open

Dtype selective build: disable when not in xplat and add fail msg #11090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/selective_build/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def define_common_targets():
deps = [
":select_ops_in_dict",
],
dtype_selective_build = True,
dtype_selective_build = is_xplat(),
visibility = ["//executorch/..."],
)

Expand All @@ -78,7 +78,7 @@ def define_common_targets():
deps = [
":select_ops_in_dict",
],
dtype_selective_build = True,
dtype_selective_build = is_xplat(),
visibility = ["//executorch/..."],
)

Expand Down
3 changes: 1 addition & 2 deletions shim_et/xplat/executorch/codegen/codegen.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,8 +644,7 @@ def executorch_generated_lib(

if dtype_selective_build:
if not expose_operator_symbols and not is_xplat():
# TODO(T225169282): make this a fail once internal cases move to xplat.
warning("""
fail("""
Dtype selective build with expose_operator_symbols=False works only in xplat -
there are undefined symbols otherwise. Please try to use xplat, or talk to the
executorch team. Setting expose_operator_symbols=True is not recommended as the
Expand Down
Loading