Updates to use torchao's updated choose_qparams_affine and quantize/dequantize_affine #11070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jainapurva wants to merge 4 commits into pytorch:main from jainapurva:export-D75228037

Contributor

jainapurva commented May 22, 2025 •

edited

Loading

Summary: Updates to use torchao's updated choose_qparams_affine and quantize/dequantize_affine. Remove zero_point_domain dependency

Differential Revision: D75228037

jainapurva requested review from JacobSzwejbka, tarun292, larryliu0820, digantdesai and mcr229 as code owners

May 22, 2025 17:22

pytorch-bot bot commented May 22, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11070

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit b205f2f with merge base a6e2961 ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / linux / linux-job (gh) (trunk failure)
examples/models/llama/tests/test_export_llama_lib.py::ExportLlamaLibTest::test_has_expected_ops_and_op_counts
pull / unittest-editable / linux / linux-job (gh) (trunk failure)
examples/models/llama/tests/test_export_llama_lib.py::ExportLlamaLibTest::test_has_expected_ops_and_op_counts

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented May 22, 2025

This pull request was exported from Phabricator. Differential Revision: D75228037

facebook-github-bot added the fb-exported label

mcr229 added the release notes: none label

Contributor

metascroy commented May 22, 2025

@jainapurva I think this needs to be accompanied by a torchao pin bump in OSS executorch (checkout the torchao submodule in ET and bump the commit hash)

metascroy requested changes

View reviewed changes

Contributor

metascroy left a comment

Needs a pin bump

Contributor

facebook-github-bot commented May 22, 2025

This pull request was exported from Phabricator. Differential Revision: D75228037

jainapurva added a commit to jainapurva/executorch that referenced this pull request


          Updates to use torchao's updated choose_qparams_affine and quantize/d…

5e281f8

…equantize_affine (pytorch#11070)

Summary:
Pull Request resolved: pytorch#11070

Updates to use torchao's updated choose_qparams_affine and quantize/dequantize_affine without the zero_point_domain arg

Differential Revision: D75228037

jainapurva force-pushed the export-D75228037 branch from 8ffbfeb to 5e281f8 Compare

May 22, 2025 18:00

jainapurva requested a review from GregoryComer as a code owner

May 22, 2025 18:00

Contributor

facebook-github-bot commented May 22, 2025

This pull request was exported from Phabricator. Differential Revision: D75228037

jainapurva added a commit to jainapurva/executorch that referenced this pull request


          Updates to use torchao's updated choose_qparams_affine and quantize/d…

a32edca

…equantize_affine (pytorch#11070)

Summary:
Pull Request resolved: pytorch#11070

Updates to use torchao's updated choose_qparams_affine and quantize/dequantize_affine without the zero_point_domain arg

Differential Revision: D75228037

jainapurva force-pushed the export-D75228037 branch from 5e281f8 to a32edca Compare

May 22, 2025 18:17

Contributor

facebook-github-bot commented May 22, 2025

This pull request was exported from Phabricator. Differential Revision: D75228037

jainapurva added a commit to jainapurva/executorch that referenced this pull request


          Updates to use torchao's updated choose_qparams_affine and quantize/d…

4d3b9bf

…equantize_affine (pytorch#11070)

Summary:
Pull Request resolved: pytorch#11070

Updates to use torchao's updated choose_qparams_affine and quantize/dequantize_affine without the zero_point_domain arg

Differential Revision: D75228037

jainapurva force-pushed the export-D75228037 branch from 1552354 to 4d3b9bf Compare

May 22, 2025 18:48

Contributor

facebook-github-bot commented May 22, 2025

This pull request was exported from Phabricator. Differential Revision: D75228037

jainapurva added a commit to jainapurva/executorch that referenced this pull request


          Updates to use torchao's updated choose_qparams_affine and quantize/d…

8f36f21

…equantize_affine (pytorch#11070)

Summary:
Pull Request resolved: pytorch#11070

Updates to use torchao's updated choose_qparams_affine and quantize/dequantize_affine without the zero_point_domain arg

Differential Revision: D75228037

jainapurva force-pushed the export-D75228037 branch from 4d3b9bf to 8f36f21 Compare

May 22, 2025 18:53


          Updates to use torchao's updated choose_qparams_affine and quantize/d…

6b3810f

…equantize_affine (pytorch#11070)

Summary:
Pull Request resolved: pytorch#11070

Updates to use torchao's updated choose_qparams_affine and quantize/dequantize_affine without the zero_point_domain arg

Differential Revision: D75228037

Contributor

facebook-github-bot commented May 22, 2025

This pull request was exported from Phabricator. Differential Revision: D75228037

jainapurva force-pushed the export-D75228037 branch from 8f36f21 to 6b3810f Compare

May 22, 2025 19:11


          Merge branch 'main' into export-D75228037

04e034f

Contributor

facebook-github-bot commented May 22, 2025

@jainapurva has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jerryzh168 approved these changes

View reviewed changes

jerryzh168 requested a review from metascroy

May 22, 2025 22:56

Contributor

jerryzh168 commented May 22, 2025

@metascroy please take a look again

mcr229 approved these changes

View reviewed changes


          Merge branch 'main' into export-D75228037

e7c9290

Contributor

facebook-github-bot commented May 23, 2025

@jainapurva has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          Merge branch 'main' into export-D75228037

b205f2f

Contributor

facebook-github-bot commented May 23, 2025

@jainapurva has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jerryzh168 jerryzh168 approved these changes

mcr229 mcr229 approved these changes

JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

tarun292 Awaiting requested review from tarun292 tarun292 is a code owner

larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

metascroy Awaiting requested review from metascroy

Requested changes must be addressed to merge this pull request.

Labels

CLA Signed fb-exported release notes: none