BugFix: Modify TPS metric calculation. Add default cpu threads for hybrid CPU system. #11063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces two minor fix for Llama runner:
len(tokens) - len(prompt_tokens) - 1
.num_threads
to 4 as a general setting.Release notes: examples
Test plan
CPU: Intel Core-14900KF. 8 performance cores and 16 efficient cores, with total 32 CPU threads.
System: Ubuntu 22.04
Testing command:
without this PR
with this PR