Refactor write_tensor_or_raise_error to Return Error Codes Instead of Raising Errors #11051
+31
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11051
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d11099c with merge base 2d0d7d7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75111482 |
Gasoonjia
approved these changes
May 21, 2025
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
May 21, 2025
… Raising Errors (pytorch#11051) Summary: This PR to make the write_tensor_or_raise_error function error out more gracefully by updating the signature of write_tensor_or_raise_error to return executorch::runtime::Result<long> instead of long Check the error code and raise an error if needed after invoking write_tensor_or_return_error function using ET_CHECK_MSG Reviewed By: Gasoonjia Differential Revision: D75111482
Juntian777
force-pushed
the
export-D75111482
branch
from
6f8116e to
e7f5ff1
Compare
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
May 21, 2025
… Raising Errors (pytorch#11051) Summary: This PR to make the write_tensor_or_raise_error function error out more gracefully by updating the signature of write_tensor_or_raise_error to return executorch::runtime::Result<long> instead of long Check the error code and raise an error if needed after invoking write_tensor_or_return_error function using ET_CHECK_MSG Reviewed By: Gasoonjia Differential Revision: D75111482
Juntian777
force-pushed
the
export-D75111482
branch
from
e7f5ff1 to
d453eb3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75111482 |
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
May 21, 2025
… Raising Errors (pytorch#11051) Summary: Pull Request resolved: pytorch#11051 This PR to make the write_tensor_or_raise_error function error out more gracefully by updating the signature of write_tensor_or_raise_error to return executorch::runtime::Result<long> instead of long Check the error code and raise an error if needed after invoking write_tensor_or_return_error function using ET_CHECK_MSG Reviewed By: Gasoonjia Differential Revision: D75111482
Juntian777
force-pushed
the
export-D75111482
branch
from
d453eb3 to
1833525
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75111482 |
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
May 21, 2025
… Raising Errors (pytorch#11051) Summary: Pull Request resolved: pytorch#11051 This PR to make the write_tensor_or_raise_error function error out more gracefully by updating the signature of write_tensor_or_raise_error to return executorch::runtime::Result<long> instead of long Check the error code and raise an error if needed after invoking write_tensor_or_return_error function using ET_CHECK_MSG Reviewed By: Gasoonjia Differential Revision: D75111482
Juntian777
force-pushed
the
export-D75111482
branch
2 times, most recently
from
b45ad8d to
a521443
Compare
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
May 22, 2025
… Raising Errors (pytorch#11051) Summary: This PR to make the write_tensor_or_raise_error function error out more gracefully by updating the signature of write_tensor_or_raise_error to return executorch::runtime::Result<long> instead of long Check the error code and raise an error if needed after invoking write_tensor_or_return_error function using ET_CHECK_MSG Reviewed By: Gasoonjia Differential Revision: D75111482
… Raising Errors (pytorch#11051) Summary: Pull Request resolved: pytorch#11051 This PR to make the write_tensor_or_raise_error function error out more gracefully by updating the signature of write_tensor_or_raise_error to return executorch::runtime::Result<long> instead of long Check the error code and raise an error if needed after invoking write_tensor_or_return_error function using ET_CHECK_MSG Reviewed By: Gasoonjia Differential Revision: D75111482
|
This pull request was exported from Phabricator. Differential Revision: D75111482 |
Juntian777
force-pushed
the
export-D75111482
branch
from
a521443 to
d11099c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR to make the write_tensor_or_raise_error function error out more gracefully by updating the signature of write_tensor_or_raise_error to return executorch::runtime::Result instead of long
Check the error code and raise an error if needed after invoking write_tensor_or_return_error function using ET_CHECK_MSG
Reviewed By: Gasoonjia
Differential Revision: D75111482