Skip to content

Qualcomm AI Engine Direct - GA CvT #11036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Qualcomm AI Engine Direct - GA CvT #11036

merged 1 commit into from
Jun 5, 2025

Conversation

shewu-quic
Copy link
Collaborator

Summary:

  • Add CvT example script
  • Add the test for CvT
  • Fix missing quant config for torch.ops.aten.split_with_sizes.default

@shewu-quic shewu-quic requested a review from cccclai as a code owner May 21, 2025 06:43
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11036

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 20ec29f with merge base b2c02fe (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shewu-quic shewu-quic force-pushed the dev1/hutton/ga_cvt branch from b5e5686 to 4b3a223 Compare May 21, 2025 07:46
@shewu-quic shewu-quic force-pushed the dev1/hutton/ga_cvt branch from 4b3a223 to 3e7d0ec Compare June 2, 2025 02:12
cccclai
cccclai approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shewu-quic shewu-quic force-pushed the dev1/hutton/ga_cvt branch from 3e7d0ec to 49bd484 Compare June 3, 2025 04:38
@shewu-quic
Qualcomm AI Engine Direct - GA CvT
20ec29f 
Summary:
- Add CvT example script
  - torch.einsum("bhlk,bhtk->bhlt", [query, key]) will result in prepare
    failed due to 5D tensor with decompose_einsum.
  - Once HTP fixed, graph transforms "attention_forward_without_einsum" can be removed
- Add the test for CvT
- Fix missing quant config for torch.ops.aten.split_with_sizes.default
@shewu-quic shewu-quic force-pushed the dev1/hutton/ga_cvt branch from 49bd484 to 20ec29f Compare June 5, 2025 09:11
@cccclai cccclai merged commit e42dafc into pytorch:main Jun 5, 2025
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shewu-quic @cccclai @facebook-github-bot