Handle unsupported pybind inputs non-fatally #10670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10670
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 7eea284 with merge base 94f7b10 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74118509 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
May 3, 2025
Summary: Currently, passing unsupported python types to pybind method execution, such as lists, dicts, or tuples, will crash the kernel due to hitting an assert. This PR updates the logic to raise an exception, which gets nicely bubbled up to the notebook. This gives the user a nicer error message and does not crash the bento/jupyter process. Differential Revision: D74118509
GregoryComer
force-pushed
the
export-D74118509
branch
from
4bc7d3c to
f5c69ce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74118509 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
May 3, 2025
Summary: Currently, passing unsupported python types to pybind method execution, such as lists, dicts, or tuples, will crash the kernel due to hitting an assert. This PR updates the logic to raise an exception, which gets nicely bubbled up to the notebook. This gives the user a nicer error message and does not crash the bento/jupyter process. Differential Revision: D74118509
GregoryComer
force-pushed
the
export-D74118509
branch
from
f5c69ce to
3888cc5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74118509 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
May 3, 2025
Summary: Currently, passing unsupported python types to pybind method execution, such as lists, dicts, or tuples, will crash the kernel due to hitting an assert. This PR updates the logic to raise an exception, which gets nicely bubbled up to the notebook. This gives the user a nicer error message and does not crash the bento/jupyter process. Differential Revision: D74118509
GregoryComer
force-pushed
the
export-D74118509
branch
from
3888cc5 to
4960bd2
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
May 3, 2025
Summary: Currently, passing unsupported python types to pybind method execution, such as lists, dicts, or tuples, will crash the kernel due to hitting an assert. This PR updates the logic to raise an exception, which gets nicely bubbled up to the notebook. This gives the user a nicer error message and does not crash the bento/jupyter process. Differential Revision: D74118509
GregoryComer
force-pushed
the
export-D74118509
branch
from
4960bd2 to
8642496
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74118509 |
Summary: Pull Request resolved: pytorch#10670 Currently, passing unsupported python types to pybind method execution, such as lists, dicts, or tuples, will crash the kernel due to hitting an assert. This PR updates the logic to raise an exception, which gets nicely bubbled up to the notebook. This gives the user a nicer error message and does not crash the bento/jupyter process. Differential Revision: D74118509
|
This pull request was exported from Phabricator. Differential Revision: D74118509 |
GregoryComer
force-pushed
the
export-D74118509
branch
from
8642496 to
7eea284
Compare
tarun292
approved these changes
May 5, 2025
|
This is great. Thanks for adding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently, passing unsupported python types to pybind method execution, such as lists, dicts, or tuples, will crash the kernel due to hitting an assert. This PR updates the logic to raise an exception, which gets nicely bubbled up to the notebook. This gives the user a nicer error message and does not crash the bento/jupyter process.
Differential Revision: D74118509