Skip to content

Fix ios benchmark app #10543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

Fix ios benchmark app #10543

merged 3 commits into from
Apr 29, 2025

Conversation

jackzhxng
Copy link
Contributor

Fixes the ios benchmark app, dependent on pytorch-labs/tokenizers#62

Copy link

pytorch-bot bot commented Apr 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10543

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 3 Pending

As of commit 6ecfa98 with merge base c723212 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 29, 2025
@shoumikhin
Copy link
Contributor

LGTM assuming the app was able to measure some llama model perf successfully.
Please address the LLaMA app too.

@facebook-github-bot
Copy link
Contributor

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng
Copy link
Contributor Author

Manually validated the benchmarking app by benchmarking stories110M and Qwen3

@jackzhxng jackzhxng merged commit 29fee77 into main Apr 29, 2025
89 of 94 checks passed
@jackzhxng jackzhxng deleted the jz/fix-benchmark-app-ios branch April 29, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants