Skip to content

Run iPhone benchmark on private devices #10380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Run iPhone benchmark on private devices #10380

merged 2 commits into from
Apr 23, 2025

Conversation

@huydhn huydhn requested review from guangy10 and yangw-dev April 23, 2025 00:53
Copy link

pytorch-bot bot commented Apr 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10380

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit ea1cab8 with merge base 59870c5 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@huydhn huydhn added topic: not user facing and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 23, 2025
@huydhn huydhn temporarily deployed to upload-benchmark-results April 23, 2025 02:51 — with GitHub Actions Inactive
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@guangy10
Copy link
Contributor

iOS 15. Is it a typo, you mean iOS 18?

@huydhn
Copy link
Contributor Author

huydhn commented Apr 23, 2025

iOS 15. Is it a typo, you mean iOS 18?

Yeah, we have iPhone 15 iOS 18 and iPhone 15 iOS 17.2.1

@huydhn
Copy link
Contributor Author

huydhn commented Apr 23, 2025

After looking at the test run on the dashboard. The devices shows up as Apple iPhone 15 (iOS 18.0) and Apple iPhone 15 Pro Max (iOS 17.2.1) which couldn't be separate from the regular public iOS devices. I will land this but disable the schedule for now to avoid confusion when this runs in main. I'll work on adding the device pool ID & device ID and enable the workflow on that PR.

@huydhn huydhn temporarily deployed to upload-benchmark-results April 23, 2025 05:58 — with GitHub Actions Inactive
@huydhn huydhn merged commit 4450532 into main Apr 23, 2025
191 of 194 checks passed
@huydhn huydhn deleted the apple-private-devices branch April 23, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants