add BoxWithNMSLimit_out to DSP as a custom portable op #10157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonglinpeng
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10157
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 36a8f74 with merge base bb60c25 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72275947 |
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Apr 14, 2025
Summary: Callsite: https://www.internalfb.com/code/fbsource/[3c01ebf76a180e7f6b5ddd8e50f4be695d85180f]/fbcode/vizard_projects/midas_haptic/model/haptic.py?lines=509-532 Reference implementation: https://www.internalfb.com/code/fbsource/fbcode/caffe2/fb/custom_ops/maskrcnn/box_with_nms_limit.cpp This op will be migrated and supported by ExecuTorch as a portable op in the future. Differential Revision: D72275947
zonglinpeng
force-pushed
the
export-D72275947
branch
from
07484ab to
6dbbee7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72275947 |
zonglinpeng
force-pushed
the
export-D72275947
branch
from
6dbbee7 to
a6299ad
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Apr 14, 2025
Summary: Pull Request resolved: pytorch#10157 Callsite: https://www.internalfb.com/code/fbsource/[3c01ebf76a180e7f6b5ddd8e50f4be695d85180f]/fbcode/vizard_projects/midas_haptic/model/haptic.py?lines=509-532 Reference implementation: https://www.internalfb.com/code/fbsource/fbcode/caffe2/fb/custom_ops/maskrcnn/box_with_nms_limit.cpp This op will be migrated and supported by ExecuTorch as a portable op in the future. Differential Revision: D72275947
mcremon-meta
approved these changes
Apr 15, 2025
zonglinpeng
force-pushed
the
export-D72275947
branch
from
a6299ad to
b0b0a89
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Apr 16, 2025
Summary: Callsite: https://www.internalfb.com/code/fbsource/[3c01ebf76a180e7f6b5ddd8e50f4be695d85180f]/fbcode/vizard_projects/midas_haptic/model/haptic.py?lines=509-532 Reference implementation: https://www.internalfb.com/code/fbsource/fbcode/caffe2/fb/custom_ops/maskrcnn/box_with_nms_limit.cpp This op will be migrated and supported by ExecuTorch as a portable op in the future. Differential Revision: D72275947
Summary: Pull Request resolved: pytorch#10157 Callsite: https://www.internalfb.com/code/fbsource/[3c01ebf76a180e7f6b5ddd8e50f4be695d85180f]/fbcode/vizard_projects/midas_haptic/model/haptic.py?lines=509-532 Reference implementation: https://www.internalfb.com/code/fbsource/fbcode/caffe2/fb/custom_ops/maskrcnn/box_with_nms_limit.cpp This op will be migrated and supported by ExecuTorch as a portable op in the future. Differential Revision: D72275947
|
This pull request was exported from Phabricator. Differential Revision: D72275947 |
zonglinpeng
force-pushed
the
export-D72275947
branch
from
b0b0a89 to
36a8f74
Compare
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Differential Revision: D72275947 Pull Request resolved: pytorch#10157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR to be changed when NMS is migrated to ET as an portable op
Changed the c10 client to be used by internal party
Callsite: https://www.internalfb.com/code/fbsource/[3c01ebf76a180e7f6b5ddd8e50f4be695d85180f]/fbcode/vizard_projects/midas_haptic/model/haptic.py?lines=509-532
Reference implementation: https://www.internalfb.com/code/fbsource/fbcode/caffe2/fb/custom_ops/maskrcnn/box_with_nms_limit.cpp
This op will be migrated and supported by ExecuTorch as a portable op in the future.
Differential Revision: D72275947