Skip to content

[ez] Remove duplicate log_intermediate_output_delegate_helper #10053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zhenyan-zhang-meta
Copy link
Contributor

@zhenyan-zhang-meta zhenyan-zhang-meta commented Apr 10, 2025

Stack from ghstack (oldest at bottom):

  • Remove duplicate log_intermediate_output_delegate_helper()
  • Return directly rather than getting the value first.

Differential Revision: D72768360

- Remove duplicate `log_intermediate_output_delegate_helper()`
- Return directly rather than getting the value first.

Differential Revision: [D72768360](https://our.internmc.facebook.com/intern/diff/D72768360/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10053

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 5 Pending

As of commit 1bd2923 with merge base 1facfa9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zhenyan-zhang-meta pushed a commit that referenced this pull request Apr 10, 2025
- Remove duplicate `log_intermediate_output_delegate_helper()`
- Return directly rather than getting the value first.

Differential Revision: [D72768360](https://our.internmc.facebook.com/intern/diff/D72768360/)

ghstack-source-id: 277231224
Pull Request resolved: #10053
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72768360

@zhenyan-zhang-meta
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@zhenyan-zhang-meta
Copy link
Contributor Author

#9971

@zhenyan-zhang-meta
Copy link
Contributor Author

@Gasoonjia already done in #10032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants