Skip to content

Various typo and 0.6 specific changes to CONTRIBUTING.md #10016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

Jack-Khuu
Copy link
Contributor

Summary

title

Test plan

md

@Jack-Khuu Jack-Khuu requested a review from metascroy April 9, 2025 21:10
Copy link

pytorch-bot bot commented Apr 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10016

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending

As of commit 8ba03ee with merge base 771588a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2025
@Jack-Khuu
Copy link
Contributor Author

Note some changes slipped in that aren't only in 0.6, but can separately be merged back to main

@metascroy metascroy merged commit 2f012a6 into release/0.6 Apr 9, 2025
78 of 79 checks passed
@metascroy metascroy deleted the Jack-Khuu-patch-2 branch April 9, 2025 21:47
Jack-Khuu added a commit that referenced this pull request Apr 9, 2025
Pulling in the non 0.6 changes from:

#10006
#10016
Jack-Khuu added a commit that referenced this pull request Apr 9, 2025
### Summary

Pulling in the non 0.6 changes from:

#10006
#10016

### Test plan
md
kimishpatel added a commit that referenced this pull request Apr 10, 2025
…tions (#10025)

### Summary

Pulling in the non 0.6 changes from:

#10006
#10016

### Test plan
md


Internal:
<< DO NOT EDIT BELOW THIS LINE >>

**GitHub Author**: Jack-Khuu <jackkhuu@fb.com> (Meta Employee)
**GitHub Repo**: [pytorch/executorch](https://github.com/pytorch/executorch)
**GitHub Pull Request**: [#10025](#10025)

Initially generated by: https://www.internalfb.com/intern/sandcastle/job/9007201034847118/

This was imported as part of a Diff Train.
Please review this as soon as possible. Since it is a direct copy of a commit on
GitHub, there shouldn't be much to do.

diff-train-source-id: 4bd7798

Differential Revision: [D72750049](https://our.internmc.facebook.com/intern/diff/D72750049/)

[ghstack-poisoned]
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
### Summary

Pulling in the non 0.6 changes from:

#10006
#10016

### Test plan
md
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
### Summary

Pulling in the non 0.6 changes from:

pytorch#10006
pytorch#10016

### Test plan
md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants