Closed
Description
🚀 The feature, motivation and pitch
We have adopted datasink as the primary output data dumping pipeline in ETDumpGen, and we've implemented two datasinks, BufferDataSink and FileDataSink. #9033 has more details.
However, we only tested BufferDataSink in the ETDumpGen's test (e.g. https://github.com/pytorch/executorch/blob/main/devtools/etdump/tests/etdump_test.cpp#L237) but still missing FileDataSink test.
So, for this issue we'd love to bring FileDataSink into ETDumpGen's test.
You can mimic what we've done for BufferDataSink to solve the problem, and https://github.com/pytorch/executorch/blob/main/extension/data_loader/test/file_data_loader_test.cpp would be a good example about how to create a temporary file for testing.
Alternatives
No response
Additional context
No response
RFC (Optional)
No response
cc @Jack-Khuu