-
Notifications
You must be signed in to change notification settings - Fork 646
Open
Labels
Android_GAgood first issueGood for newcomersGood for newcomersmodule: androidIssues related to Android code, build, and executionIssues related to Android code, build, and executiontriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
Description
🚀 The feature, motivation and pitch
Right now we have two places loading library https://github.com/search?q=repo%3Apytorch%2Fexecutorch%20loadlib&type=code
Instead, can we just have one place, in a new file say Runtime.java?
class Runtime {
static {
// Loads libexecutorch.so from jniLibs
NativeLoader.loadLibrary("executorch");
}
static boolean isInitialized() {
// maybe check something else?
}
}
Then in NativePeer.java and LlmModule.java
static {
if (!Runtime.isInitialized()) {
throw ...
}
}
Alternatives
No response
Additional context
No response
RFC (Optional)
No response
cc @cbilgin
Metadata
Metadata
Assignees
Labels
Android_GAgood first issueGood for newcomersGood for newcomersmodule: androidIssues related to Android code, build, and executionIssues related to Android code, build, and executiontriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Type
Projects
Status
No status
Status
In Progress