Skip to content

Commit

Permalink
Fix broken images in docs (#5514)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #5514

#5475 moved the images to static folder, #5493 updated some of it but missed out on the delegate specific docs.

This diff, fixes that by replacing the image URLs that are broken

Reviewed By: cmodi-meta, svekars, kirklandsign

Differential Revision: D63135522

fbshipit-source-id: 10071b0428c203eef38500852e64f71e13ec1315
  • Loading branch information
Riandy authored and facebook-github-bot committed Sep 20, 2024
1 parent 8618607 commit 7de3f81
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ Before continuing forward, make sure to modify the tokenizer, token embedding, a
Prior to deploying the files on device, make sure to modify the tokenizer, token embedding, and model file names in examples/mediatek/executor_runner/run_llama3_sample.sh reflect what was generated during the Export Llama Model step.

<p align="center">
<img src="../screenshots/mtk_changes_to_shell_file.png" width=600>
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/mtk_changes_to_shell_file.png" width=600>
</p>

In addition, create a sample_prompt.txt file with a prompt. This will be deployed to the device in the next step.
Expand Down Expand Up @@ -150,7 +150,7 @@ adb shell
```

<p align="center">
<img src="../screenshots/mtk_output.png" width=800>
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/mtk_output.png" width=800>
</p>

## Reporting Issues
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ popd
If the app successfully run on your device, you should see something like below:

<p align="center">
<img src="https://github.com/pytorch/executorch/blob/main/examples/demo-apps/android/LlamaDemo/docs/screenshots/opening_the_app_details.png" width=800>
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/opening_the_app_details.png" width=800>
</p>

## Reporting Issues
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ popd
If the app successfully run on your device, you should see something like below:

<p align="center">
<img src="../screenshots/opening_the_app_details.png" width=800>
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/opening_the_app_details.png" width=800>
</p>

## Reporting Issues
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,19 +95,19 @@ Note: To access logs, link against the Debug build of the ExecuTorch runtime, i.
For more details integrating and Running ExecuTorch on Apple Platforms, checkout this [link](https://pytorch.org/executorch/main/apple-runtime.html).

<p align="center">
<img src="../screenshots/ios_demo_app_swift_pm.png" alt="iOS LLaMA App Swift PM" width="600">
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/ios_demo_app_swift_pm.png" alt="iOS LLaMA App Swift PM" width="600">
</p>

Then select which ExecuTorch framework should link against which target.

<p align="center">
<img src="../screenshots/ios_demo_app_choosing_package.png" alt="iOS LLaMA App Choosing package" width="600">
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/ios_demo_app_choosing_package.png" alt="iOS LLaMA App Choosing package" width="600">
</p>

Click “Run” to build the app and run in on your iPhone. If the app successfully run on your device, you should see something like below:

<p align="center">
<img src="../screenshots/ios_demo_app_mps.jpg" alt="iOS LLaMA App mps" width="300">
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/ios_demo_app_mps.jpg" alt="iOS LLaMA App mps" width="300">
</p>

## Reporting Issues
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,25 +95,25 @@ Note: To access logs, link against the Debug build of the ExecuTorch runtime, i.
For more details integrating and Running ExecuTorch on Apple Platforms, checkout this [link](https://pytorch.org/executorch/main/apple-runtime.html).

<p align="center">
<img src="../screenshots/ios_demo_app_swift_pm.png" alt="iOS LLaMA App Swift PM" width="600">
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/ios_demo_app_swift_pm.png" alt="iOS LLaMA App Swift PM" width="600">
</p>

Then select which ExecuTorch framework should link against which target.

<p align="center">
<img src="../screenshots/ios_demo_app_choosing_package.png" alt="iOS LLaMA App Choosing package" width="600">
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/ios_demo_app_choosing_package.png" alt="iOS LLaMA App Choosing package" width="600">
</p>

Click “Run” to build the app and run in on your iPhone. If the app successfully run on your device, you should see something like below:

<p align="center">
<img src="../screenshots/ios_demo_app.jpg" alt="iOS LLaMA App" width="300">
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/ios_demo_app.jpg" alt="iOS LLaMA App" width="300">
</p>

For Llava 1.5 models, you can select and image (via image/camera selector button) before typing prompt and send button.

<p align="center">
<img src="../screenshots/ios_demo_app_llava.jpg" alt="iOS LLaMA App" width="300">
<img src="https://raw.githubusercontent.com/pytorch/executorch/refs/heads/main/docs/source/_static/img/ios_demo_app_llava.jpg" alt="iOS LLaMA App" width="300">
</p>

## Reporting Issues
Expand Down

0 comments on commit 7de3f81

Please sign in to comment.