This repository was archived by the owner on Aug 15, 2025. It is now read-only.
[hotfix] follow up changes to rocm3.8 #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterddr
commented
Sep 24, 2020
| @@ -9,7 +9,7 @@ set -e | |||
|
|
|||
| # Upload for all CUDA/cpu versions if not given one to use | |||
| if [[ -z "$CUDA_VERSIONS" ]]; then | |||
| export CUDA_VERSIONS=('cpu' 'cu92' 'cu100' 'cu101' 'cu102' 'cu110' 'rocm3.7') | |||
| export CUDA_VERSIONS=('cpu' 'cu92' 'cu100' 'cu101' 'cu102' 'cu110' 'rocm3.7' 'rocm3.8') | |||
There was a problem hiding this comment.
@seemethere should we add this together with the nightly PR or should we add it AFTER the files are being uploaded?
There was a problem hiding this comment.
it doesn't actually matter, this will work even if there are no rocm3.8 packages available
walterddr
requested review from
seemethere and
jeffdaily
and removed request for
seemethere
seemethere
approved these changes
Sep 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up on #528