This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Add promotion script for pytorch releases #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
walterddr
approved these changes
Sep 17, 2020
| promote_conda torchcsprng conda "${TORCHCSPRNG_VERSION}" | ||
|
|
||
| # Uncomment these to promote to pypi | ||
| # promote_pypi torch "${PYTORCH_VERSION}" |
There was a problem hiding this comment.
would this script be used inside pytorch/pytorch/.circleci? I was wondering if we can just use env var to control this?
There was a problem hiding this comment.
Or maybe a command line argument
There was a problem hiding this comment.
No we typically promotion is the last manual step in the release process.
As part of this, we make it purposefully difficult to promote to PyPI since it cannot be undone.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eli Uriegas eliuriegas@fb.com