-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows use mkl static lib (take 2) #1798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a test PR against PyTorch/PyTorch
Triggerred test from the dummy PR: pytorch/pytorch#124853 |
After pytorch/pytorch#124925 merged, the static mkl not support issue is gone. |
Final test: pytorch/pytorch#124853 |
@malfet All test passed. |
I am getting an error with latest Windows AMI:
and finaly failing:
|
This reverts commit eebc2f0.
resubmit #1790 with fix PR #1797.
From pytorch issue: pytorch/pytorch#124009 I found libtorch seems use shared mkl lib and missing some mkl dll files.
Tested in https://github.com/pytorch/pytorch/actions/runs/8836875904/job/24264643410