Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Mar 20, 2024

@atalman atalman requested review from albanD and malfet and removed request for albanD March 20, 2024 19:16
@atalman atalman changed the title Update wheel build numpy to 2.0 Update nightly wheel build numpy to 2.0 Mar 20, 2024
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound good!

if "%DESIRED_PYTHON%" == "3.12" pip install -q --pre numpy==2.0.0b1 protobuf
if "%DESIRED_PYTHON%" == "3.11" pip install -q --pre numpy==2.0.0b1 protobuf
if "%DESIRED_PYTHON%" == "3.10" pip install -q --pre numpy==2.0.0b1 protobuf
if "%DESIRED_PYTHON%" == "3.9" pip install -q --pre numpy==2.0.0b1 protobuf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe we can make this an else to avoid having the same lines multiple times?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atalman atalman merged commit 65f8e7d into pytorch:main Mar 20, 2024
@atalman atalman deleted the numpy20cherry_picks branch March 20, 2024 20:05
@rgommers rgommers mentioned this pull request Apr 2, 2024
3 tasks
atalman added a commit to atalman/builder that referenced this pull request Apr 4, 2024
* Update wheel build numpy to 2.0 (pytorch#1746)

* Update wheel build numpy to 2.0

* aarch64

* Update build_wheel.sh

* Simplify
atalman added a commit that referenced this pull request Apr 4, 2024
* [BE] Remove macos x86 build statements, remove python <3.8 (#1745)

* [BE] Remove macos x86 build statements, remove python <3.8

* fix

* deprecate

* Update nightly wheel build numpy to 2.0 (#1747)

* Update wheel build numpy to 2.0 (#1746)

* Update wheel build numpy to 2.0

* aarch64

* Update build_wheel.sh

* Simplify

* Install llvm-openmp for M1 PyTorch builds

Otherwise the binary will be super slow

Also drop `nomkl` as there were never mkl on Apple silicon

* Add numpy 2.0.0rc1 support to conda and wheels (#1768)

* Add numpy 2.0.0rc1 support to conda and wheels

* conda

* conda

* test

* fix

* Add numpy 2.0.0rc1 support to conda and wheels (#1769)

---------

Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants