Stop allowing some arguments to be ignored in acqf input constructors #2356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57909958 |
facebook-github-bot
added
CLA Signed
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
May 29, 2024
…pytorch#2356) Summary: Stop silently ignoring arguments that can't be safely ignored so that an exception will be naturally raised instead. Carve-outs had to be added for `AnalyticExpectedUtilityOfBestOption` because it is often used in a BOPE loop where the same arguments are passed in the preference learning and experiment candidate-generation stages. Differential Revision: D57909958
esantorella
force-pushed
the
export-D57909958
branch
from
7137407 to
886a4cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57909958 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2356 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 191 191
Lines 16711 16713 +2
=======================================
+ Hits 16708 16710 +2
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D57909958 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jun 11, 2024
…pytorch#2356) Summary: Pull Request resolved: pytorch#2356 Stop silently ignoring arguments that can't be safely ignored so that an exception will be naturally raised instead. Carve-outs had to be added for `AnalyticExpectedUtilityOfBestOption` because it is often used in a BOPE loop where the same arguments are passed in the preference learning and experiment candidate-generation stages. Reviewed By: saitcakmak Differential Revision: D57909958
esantorella
force-pushed
the
export-D57909958
branch
from
886a4cc to
804a203
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57909958 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jun 12, 2024
…pytorch#2356) Summary: Pull Request resolved: pytorch#2356 Stop silently ignoring arguments that can't be safely ignored so that an exception will be naturally raised instead. Carve-outs had to be added for `AnalyticExpectedUtilityOfBestOption` because it is often used in a BOPE loop where the same arguments are passed in the preference learning and experiment candidate-generation stages. Reviewed By: saitcakmak Differential Revision: D57909958
esantorella
force-pushed
the
export-D57909958
branch
from
804a203 to
ba28022
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57909958 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jun 13, 2024
…pytorch#2356) Summary: Pull Request resolved: pytorch#2356 Stop silently ignoring arguments that can't be safely ignored so that an exception will be naturally raised instead. Carve-outs had to be added for `AnalyticExpectedUtilityOfBestOption` because it is often used in a BOPE loop where the same arguments are passed in the preference learning and experiment candidate-generation stages. Reviewed By: saitcakmak Differential Revision: D57909958
esantorella
force-pushed
the
export-D57909958
branch
from
ba28022 to
80ac43e
Compare
…pytorch#2356) Summary: Pull Request resolved: pytorch#2356 Stop silently ignoring arguments that can't be safely ignored so that an exception will be naturally raised instead. Carve-outs had to be added for `AnalyticExpectedUtilityOfBestOption` because it is often used in a BOPE loop where the same arguments are passed in the preference learning and experiment candidate-generation stages. Reviewed By: saitcakmak Differential Revision: D57909958
|
This pull request was exported from Phabricator. Differential Revision: D57909958 |
esantorella
force-pushed
the
export-D57909958
branch
from
80ac43e to
e299af0
Compare
|
This pull request has been merged in 62c96f0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Stop silently ignoring arguments that can't be safely ignored so that an exception will be naturally raised instead.
Carve-outs had to be added for
AnalyticExpectedUtilityOfBestOptionbecause it is often used in a BOPE loop where the same arguments are passed in the preference learning and experiment candidate-generation stages.Differential Revision: D57909958