New directory for community contributions

[saitcakmak]

Summary: Establishes the directory structure for BoTorch community contributions, associated notebooks & unit tests. Updates CONTRIBUTING.md with instructions on where each type of contribution should be made.

Differential Revision: D52747159

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D52747159

[facebook-github-bot]

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D52747159

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D52747159

[Balandat]

Thanks for putting this up. Curious why you chose this module structure over a top-level community folder (where the import path would be botorch.community.acquisition... rather than botorch_community.acquisition...). Would this cause any import headaches?

If we keep the current setup, should we rename community_notebooks to notebooks_community for consistency?

[saitcakmak]

Curious why you chose this module structure over a top-level community folder (where the import path would be botorch.community.acquisition... rather than botorch_community.acquisition...).

I've considered both and went with the top-level folder for clearer separation between the two. I am also not a fan of many level deep directory structures, particularly when there's repetition (e.g., we would have botorch.models & botorch.community.models etc.). I think the top-level setup will make it easier to setup separate CIs for the two.

Would this cause any import headaches?

I didn't run into any issues in my testing. The example test & notebooks run fine after pip install -e ".[dev]".

If we keep the current setup, should we rename community_notebooks to notebooks_community for consistency?

We can, though I like the sound of community_notebooks better. FWIW, the notebooks directory doesn't include the notebooks we have on the website (those are in tutorials). It only has the tutorial performance tracking notebook, which is quite different than the notebooks we're targeting for the new directory.

[facebook-github-bot]

@saitcakmak merged this pull request in ac19e24.