Skip to content

PosteriorStandardDeviation docstring correction and upgrades to other documentation #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

esantorella
Copy link
Member

Motivation

  • Add Posterior Standard Deviation acquisition function #2060 introduced a typo in a docstring where PosteriorMean was used instead of PosteriorStandardDeviation
  • The SingleTaskGP and "Getting Started" documentation use single-precision data and non-standardized outcome data, which is not recommended usage and raises warnings. I changed the documentation to use an outcome transform and double-precision data.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

Related PRs

#2060

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 25, 2023
@facebook-github-bot
Copy link
Contributor

@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2071 (9aaa707) into main (fc6fdba) will not change coverage.
The diff coverage is n/a.

❗ Current head 9aaa707 differs from pull request most recent head 30a1276. Consider uploading reports for the commit 30a1276 to get more accurate results

@@            Coverage Diff            @@
##              main     #2071   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines        15859     15859           
=========================================
  Hits         15859     15859           
Files Coverage Δ
botorch/acquisition/analytic.py 100.00% <ø> (ø)
botorch/models/gp_regression.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot
Copy link
Contributor

@esantorella merged this pull request in 84245d5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. documentation Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants