-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default gpu metric backend #2501
Closed
Closed
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
be4e923
add torch backend for memory metric
FindHao 9a180db
update metric backend doc
FindHao 9015ee2
update doc; add it to tritonbench
FindHao ecf1139
fix format
FindHao 2dd6ca9
keep name same with torchbench
FindHao 4820d6a
fix lint
FindHao 4398557
change default gpu metric backend
FindHao 8b48eea
rename default to torch
FindHao 3fbd962
Merge branch 'main' into findhao/operatorbench7
FindHao 87ed667
Merge branch 'main' into findhao/operatorbench7
FindHao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,6 +92,18 @@ def get_parser(args=None): | |
default=None, | ||
help="Metrics to collect, split with comma. E.g., --metrics latency,tflops,speedup.", | ||
) | ||
parser.add_argument( | ||
"--metrics-gpu-backend", | ||
choices=["default", "nvml"], | ||
default="default", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's change the default mode name to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. renamed in 8b48eea |
||
help=( | ||
"Specify the backend [default, nvml] to collect metrics. In all modes, the latency " | ||
"(execution time) is always collected using `time.time_ns()`. The CPU peak memory " | ||
"usage is collected by `psutil.Process()`. In nvml mode, the GPU peak memory usage " | ||
"is collected by the `nvml` library. In default mode, the GPU peak memory usage is " | ||
"collected by `torch.cuda.max_memory_allocated()`." | ||
), | ||
) | ||
parser.add_argument( | ||
"--only", | ||
default=None, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, let's change the default backend name to
torch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed in 8b48eea