[Fix] loudness: prevent NaN when all blocks are below absolute threshold #4110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
loudness()function intorchaudio.functionalimplements the ITU-R BS.1770-4 loudness measurement. It applies both absolute and relative gating to compute energy-averaged LKFS values.Issue
When all audio blocks are below the absolute gating threshold (
gamma_abs = -70), the computation ofenergy_filteredinvolves division by the count of gated blocks, which is zero in this scenario. This results in a NaN output. This edge case commonly occurs for very quiet or silent audio signals.Changes
torch.whereto safely handle cases where the count of gated blocks is zero.energy_filteredis set to zero.abs_gated_blocksandrel_gated_blocks) are used to clearly distinguish absolute and relative gating steps.Impact