Skip to content

Conversation

@pearu
Copy link
Collaborator

@pearu pearu commented Aug 30, 2025

As in the title.

Same as #3977 but using C++ torch::stable::Tensor API instead of C shim Tensor API.

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

@pearu pearu requested a review from a team as a code owner August 30, 2025 16:17
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4073

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@samanklesaria
Copy link
Collaborator

Looks good to me!

@pearu pearu added this to the 2.10 milestone Sep 2, 2025
@pearu pearu force-pushed the pearu/stable-abi-rnnt branch 2 times, most recently from 21fabe3 to 8ad3fe0 Compare October 28, 2025 20:57
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pearu, LGTM !

@pearu pearu force-pushed the pearu/stable-abi-rnnt branch from 8ad3fe0 to bd18091 Compare October 29, 2025 13:16
@pearu pearu merged commit 3b0e7a6 into pytorch:main Oct 29, 2025
29 of 34 checks passed
@amd-sriram
Copy link

amd-sriram commented Oct 31, 2025

@NicolasHug @samanklesaria : Is this the final version of RNNT code in torch audio or are you intending to moving out of torch audio ?

@pearu
Copy link
Collaborator Author

pearu commented Nov 1, 2025

@NicolasHug @samanklesaria : Is this the final version of RNNT code in torch audio or are you intending to moving out of torch audio ?

@amd-sriram yes, it is the final version (modulo maintenance modifications). AFAIK, this is no intention to moving RNNT out of torchaudio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants