Skip to content

Move lfilter autograd logic to Python #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Move lfilter autograd logic to Python #3957

wants to merge 1 commit into from

Conversation

NicolasHug
Copy link
Member

The code doesn't compile, this is a very rough skeleton of how I think we'll be able to remove all torch::autograd:: dependency in the C++ op of lfilter.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3957

Note: Links to docs will display an error until the docs builds have been completed.

❌ 31 New Failures, 1 Unrelated Failure

As of commit 982aa2e with merge base 70caf76 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasHug @facebook-github-bot