Add EncodingConfig #3179
Closed
Add EncodingConfig #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D43861413 |
Summary: Adds config object `EncodingConfig` and modifies `StreamWriter` to allow for passing in additional encoder configuration parameters, e.g. bit rate and compression level. Pull Request resolved: pytorch#3179 Pull Request resolved: pytorch#3164 Reviewed By: mthrok Differential Revision: D43861413 Pulled By: hwangjeff fbshipit-source-id: 65b519c82fa9d9373f718ad895fcb42d4f76a262
|
This pull request was exported from Phabricator. Differential Revision: D43861413 |
hwangjeff
force-pushed
the
export-D43861413
branch
from
71c3def
to
df66d3c
Compare
|
@hwangjeff merged this pull request in 9bb3507. |
|
Hey @hwangjeff. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds config object EncodingConfig and modifies StreamWriter to allow for passing in additional encoder configuration parameters, e.g. bit rate and compression level.
Differential Revision: D43861413
Pulled By: hwangjeff