Add frequency_impulse_response #2879
Conversation
| warnings.warn("The input frequency response should not contain negative values.") | ||
| ir = torch.fft.fftshift(torch.fft.irfft(magnitudes), dim=-1) | ||
| device, dtype = magnitudes.device, magnitudes.dtype | ||
| window = torch.hann_window(ir.size(-1), periodic=False, device=device, dtype=dtype).expand_as(ir) |
There was a problem hiding this comment.
does it have to be a hann window specifically?
There was a problem hiding this comment.
No, this is no different than the standard approach of windowing. Other windows can be used. Hann window is the standard one.
There was a problem hiding this comment.
by standard approach, I mean smoothing the side effect of bound effects.
There was a problem hiding this comment.
got it. in that case, perhaps we can consider adding an argument similar to window_fn for Spectrogram that allows for customizing the window
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @mthrok. |
This commit adds
frequency_impulse_responsefunction, which generates filter from desired frequency response.Example