-
Notifications
You must be signed in to change notification settings - Fork 273
[Float8] Fix serialization of dynamic activation fp8 #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/838
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3f56940 with merge base 65d86c6 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added a commit
that referenced
this pull request
Sep 6, 2024
stack-info: PR: #838, branch: drisspg/stack/12
3a7bcb2
to
f6047fb
Compare
drisspg
added a commit
that referenced
this pull request
Sep 6, 2024
stack-info: PR: #838, branch: drisspg/stack/12
f6047fb
to
b8c16fb
Compare
stack-info: PR: #819, branch: drisspg/stack/11
aac19a1
to
1dface2
Compare
this PR seems to contain all the changes from the previous PR? |
drisspg
added a commit
that referenced
this pull request
Sep 7, 2024
stack-info: PR: #838, branch: drisspg/stack/12
b8c16fb
to
f9acf24
Compare
stack-info: PR: #838, branch: drisspg/stack/12
f9acf24
to
3f56940
Compare
eae3b8f
to
0405f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[Float8] Fix serialization of dynamic activation fp8