Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StaticQuant] Update how block_size is calculated with Observers #815

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[StaticQuant] Update how block_size is calculated with Observers #815

merged 1 commit into from
Sep 5, 2024

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Sep 5, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/815

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit de0b7fd with merge base 848e123 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2024
@drisspg drisspg mentioned this pull request Sep 5, 2024
Merged
@drisspg drisspg force-pushed the drisspg/stack/10 branch 3 times, most recently from 591472c to 155e41c Compare September 5, 2024 05:04
jerryzh168
jerryzh168 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for adding docs and the additional test! had one comment inline, please address the comment before merging

@drisspg drisspg merged commit a1b3e67 into main Sep 5, 2024
17 checks passed
HDCharles pushed a commit that referenced this pull request Sep 9, 2024
@drisspg @HDCharles
[StaticQuant] Update how block_size is calculated with Observers (#815)
1cc9245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drisspg @jerryzh168 @facebook-github-bot