nvfp4tensor: remove duplicated tests #3090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3090
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Sep 29, 2025
Summary: These tests were previously copied to `test_nvfp4_tensor.py`, but were not deleted from `test_mx_tensor.py`. Deleting now to remove duplicate code. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: a91df7b ghstack-comment-id: 3347278536 Pull Request resolved: #3090
vkuzo
added a commit
that referenced
this pull request
Sep 29, 2025
Summary: These tests were previously copied to `test_nvfp4_tensor.py`, but were not deleted from `test_mx_tensor.py`. Deleting now to remove duplicate code. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 12f5da0 ghstack-comment-id: 3347278536 Pull Request resolved: #3090
vkuzo
added
the
topic: not user facing
jainapurva
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These tests were previously copied to
test_nvfp4_tensor.py, but werenot deleted from
test_mx_tensor.py. Deleting now to remove duplicatecode.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: