change missing ops printout back to debug #2921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Undoes part of #2908 to make the message about missing `.so` files be a debug print instead of a warning. Reason: this always happens for builds without executorch ops. Keeps the version mismatch log as a warning. Test Plan: Make this change locally in an install of torchao on an H100, verify warning no longer prints. Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2921
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 12 PendingAs of commit 5acbc29 with merge base 1bb14f8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Sep 2, 2025
Summary: Undoes part of #2908 to make the message about missing `.so` files be a debug print instead of a warning. Reason: this always happens for builds without executorch ops. Keeps the version mismatch log as a warning. Test Plan: Make this change locally in an install of torchao on an H100, verify warning no longer prints. Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Undoes part of #2908 to make the message about missing
.sofiles be a debug print instead of a warning. Reason: this always happens for builds without executorch ops.Keeps the version mismatch log as a warning.
Test Plan:
Make this change locally in an install of torchao on an H100, verify warning no longer prints.
Reviewers:
Subscribers:
Tasks:
Tags: