-
Notifications
You must be signed in to change notification settings - Fork 283
Add _apply_fn_to_data method to TorchAOBaseTensor base class #2365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
krikera
commented
Jun 12, 2025
- Implements generic pattern for applying functions to tensor components
- Uses tensor_flatten and tensor_unflatten pattern
- Fixes Add _apply_fn_to_data in AOBaseClass #2349
- Implements generic pattern for applying functions to tensor components - Uses __tensor_flatten__ and __tensor_unflatten__ pattern - Fixes pytorch#2349
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2365
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @krikera! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
thanks, if you are interested, can you add these as well ao/torchao/dtypes/fbgemm_fp8_tensor.py Lines 48 to 60 in 0afa4c1
|
@@ -49,6 +49,14 @@ def __init__(self, data): | |||
with self.assertRaisesRegex(NotImplementedError, "arg_types"): | |||
l.weight = torch.nn.Parameter(MyTensor(l.weight)) | |||
|
|||
def test_apply_fn_to_data(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be good to add a small tensor and use apply_fn_to_data to implement some common methods like clone, and make sure this works functionally