Skip to content

fix _replace_with_custom_fn_if_matches_filter in quant_api.py #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

curlup
Copy link

@curlup curlup commented May 23, 2025

so it calls filter_fn according to definition:

def _replace_with_custom_fn_if_matches_filter(
...
) -> None:
    """
    Recursively replaces each child module in `model` with the result of `replacement_fn(child)`
    if `filter_fn(child)` returns `True`.
    Args:
        ...
        filter_fn (Callable[[torch.nn.Module], bool]): The filter function to determine which modules to replace.

I think this call was a copy paste from _replace_with_custom_fn_if_matches_filter_with_name below, where it makes sense that the filter_fn gets name passed as a second argument.

If this is wrong and filter_fn should get the param, I can change this PR to have just doc string for filter_fn fixed.
Please let me know.

so it calls `filter_fn` according to definition
Copy link

pytorch-bot bot commented May 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2252

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2025
@jerryzh168
Copy link
Contributor

the doc might be outdated, it seems like it's there from the beginning: 9aaf3ec

@jerryzh168 jerryzh168 requested a review from HDCharles May 23, 2025 20:48
@jerryzh168
Copy link
Contributor

also we can probably deprecate these older APIs now? @HDCharles

@jerryzh168
Copy link
Contributor

we are ready to deprecate now I think: #2056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants