fix _replace_with_custom_fn_if_matches_filter in quant_api.py #2252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it calls
filter_fn
according to definition:I think this call was a copy paste from
_replace_with_custom_fn_if_matches_filter_with_name
below, where it makes sense that thefilter_fn
gets name passed as a second argument.If this is wrong and
filter_fn
should get the param, I can change this PR to have just doc string forfilter_fn
fixed.Please let me know.