Skip to content

Revert "Re-land the PR of "Add INT8 SDPA path for CPU"" #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented May 21, 2025

Reverts #2215

@pytorch-bot pytorch-bot bot added the ci-no-td label May 21, 2025
Copy link

pytorch-bot bot commented May 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2234

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit d5f054b with merge base 7854249 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2025
@drisspg
Copy link
Contributor Author

drisspg commented May 21, 2025

Checking to see if this fixes CI

@drisspg
Copy link
Contributor Author

drisspg commented May 21, 2025

@jerryzh168

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you

@Valentine233
Copy link
Collaborator

Hi, could you explain a bit why we need to revert #2215?

@drisspg
Copy link
Contributor Author

drisspg commented May 22, 2025

Spoke w/ @atalman offline and the failures w/ CI are unrelate to this PR (confirmed by this PR's CI). It is caused by a recent update to the base Docker image updating what version of triton we install

@drisspg drisspg closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants