Enhance test_autoquant_compile to support ROCm #2100
+20
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
petrex
commented
Apr 22, 2025
petrex
commented
- Added checks for ROCm availability alongside CUDA.
- Improved device capability checks for CUDA to ensure compatibility with bfloat16 and specific tensor shapes.
- Updated skip conditions for unsupported devices and older PyTorch versions.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2100
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 60c847f with merge base 720a177 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
petrex
added
the
topic: not user facing
|
|
|
refer to #2113 |
|
@pytorchbot rebase -b main |
petrex
force-pushed
the
rocm_autoquant
branch
2 times, most recently
from
5f113aa to
66b89a2
Compare
- Added checks for ROCm availability alongside CUDA. - Improved device capability checks for CUDA to ensure compatibility with bfloat16 and specific tensor shapes. - Updated skip conditions for unsupported devices and older PyTorch versions.
jerryzh168
reviewed
May 14, 2025
jerryzh168
reviewed
May 14, 2025
- Simplified the logic for checking supported devices by consolidating CUDA and ROCm checks. - Enhanced readability of the device capability validation for CUDA. - Updated skip conditions for unsupported devices to ensure accurate test execution.
…ed readability - Adjusted the formatting of the device check condition to enhance clarity. - Consolidated the logic for checking supported devices while maintaining functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.