use torch.float8_e8m0fnu in mx_formats #1966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1966
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 26, 2025
vkuzo
added a commit
that referenced
this pull request
Mar 26, 2025
Summary: After pytorch/pytorch#148461 lands, we can use `torch.float8_e8m0fnu` throughout our codebase and compile will still work, removing the workarounds. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 278117bb3a470bb9a28ea9a69b4d543cdd7c25d5 ghstack-comment-id: 2755728114 Pull Request resolved: #1966
facebook-github-bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Mar 26, 2025
Summary: After pytorch/pytorch#148461 lands, we can use `torch.float8_e8m0fnu` throughout our codebase and compile will still work, removing the workarounds. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 278117bb3a470bb9a28ea9a69b4d543cdd7c25d5 ghstack-comment-id: 2755728114 Pull Request resolved: #1966
vkuzo
added
the
topic: improvement
This was referenced Mar 26, 2025
jerryzh168
approved these changes
Mar 26, 2025
vkuzo
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: 1. the PR that added this test was landed after #1966, so updating to use e8m0fnu 2. the tests are not passing on my B200, so skipping for now to keep local CI clean for upcoming branch cut We should figure out what is wrong here and reenable at a future time. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 70a1abf87dfa2efe0ff310777d6edcc16c3bb9ba ghstack-comment-id: 2761624330 Pull Request resolved: #1977
vkuzo
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: 1. the PR that added this test was landed after #1966, so updating to use e8m0fnu 2. the tests are not passing on my B200, so skipping for now to keep local CI clean for upcoming branch cut We should figure out what is wrong here and reenable at a future time. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 6a2f467b2595fa7cb31bfd6d2178b5e0632ac434 ghstack-comment-id: 2761624330 Pull Request resolved: #1977
This was referenced Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After pytorch/pytorch#148461 lands, we
can use
torch.float8_e8m0fnuthroughout our codebase and compilewill still work, removing the workarounds.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: