Skip to content

Conversation

@petrex
Copy link
Collaborator

@petrex petrex commented Mar 17, 2025

TLDR: … bitsandbytes for rocm

This pull request includes a change to the jobs: section in the .github/workflows/regression_test_rocm.yml file. The change ensures that the bitsandbytes package is uninstalled and then reinstalled from a specific URL to use a development version.

Changes in jobs: section:

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1915

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f8502c0 with merge base 38b1f45 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
@petrex petrex added topic: not user facing Use this tag if you don't want this PR to show up in release notes ciflow/rocm labels Mar 17, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 17, 2025

To add the ciflow label ciflow/rocm please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/rocm label Mar 17, 2025
@jcaip jcaip self-assigned this Mar 19, 2025
@jcaip jcaip added the triaged label Mar 19, 2025
@msaroufim msaroufim self-requested a review March 26, 2025 15:24
@msaroufim msaroufim merged commit dfbd681 into pytorch:main Mar 26, 2025
22 of 24 checks passed
petrex added a commit to petrex/ao that referenced this pull request Apr 22, 2025
petrex added a commit that referenced this pull request Apr 23, 2025
Revert "Install bitsandbytes for ROCm (#1915)"

This reverts commit dfbd681.
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
Update ROCm regression test workflow to uninstall and force-reinstall bitsandbytes for rocm
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
Revert "Install bitsandbytes for ROCm (#1915)"

This reverts commit dfbd681.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm topic: not user facing Use this tag if you don't want this PR to show up in release notes triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants