Silence loud error on torchao cpu builds - #1808
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1808
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 11 PendingAs of commit 77e2b3f with merge base 7963f9c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
Errors seem like flakes |
drisspg
reviewed
Mar 3, 2025
|
|
||
| from torchao.utils import TORCH_VERSION_AT_LEAST_2_2, TORCH_VERSION_AT_LEAST_2_6 | ||
|
|
||
| logger = logging.getLogger(__name__) |
Contributor
There was a problem hiding this comment.
I think its recommend to have null handlers for library logging
logger = logging.getLogger(__name__)
logger.addHandler(logging.NullHandler())And then users can turn them on w/
https://github.com/drisspg/transformer_nuggets/blob/d04895f4adb17a7db1cd99be405019501dcb3ecf/transformer_nuggets/__init__.py#L4
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Silence loud commit * Update intmm.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this fix, just importing torchao in a cpu only environment would print
import error: triton not foundCame up live in this talk by @manuelcandales https://www.youtube.com/watch?v=0vv9K0RvOfo&ab_channel=GPUMODE
To repro on your M1 laptop