Skip to content

add a benchmark for casting a tensor to MX across dim0 and dim1 #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Feb 26, 2025

Summary:

This is useful for training, extracting into a benchmark so we can
optimize.

Test Plan:

TORCH_LOGS_FORMAT=short TORCH_LOGS=aot_graphs,output_code python benchmarks/float8/profile_lowp_training.py ~/local/tmp/20250223_test --mx_recipe_name mxfp8_emulated --experiment_filter lowp --mode_filter cast_only_dim0_dim1
// output: https://gist.github.com/vkuzo/a4e13bac7fc8ca3af10bfd5483b85b33
// currently we see two kernels, one per dim

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Feb 26, 2025

vkuzo added a commit that referenced this pull request Feb 26, 2025
Summary:

This is useful for training, extracting into a benchmark so we can
optimize.

Test Plan:

```
TORCH_LOGS_FORMAT=short TORCH_LOGS=aot_graphs,output_code python benchmarks/float8/profile_lowp_training.py ~/local/tmp/20250223_test --mx_recipe_name mxfp8_emulated --experiment_filter lowp --mode_filter cast_only_dim0_dim1
// output: https://gist.github.com/vkuzo/a4e13bac7fc8ca3af10bfd5483b85b33
// currently we see two kernels, one per dim
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: d8745ba
ghstack-comment-id: 2686344197
Pull Request resolved: #1787
Copy link

pytorch-bot bot commented Feb 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1787

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending

As of commit 2a4b6ff with merge base 8d110bf (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Feb 26, 2025
@vkuzo vkuzo merged commit 1ab1b77 into main Feb 26, 2025
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants