[1/x] mx roofline: make the script work on NVIDIA B200 #1778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1778
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 73eec2e with merge base 1ab1b77 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Feb 25, 2025
Summary: Makes the roofline estimation script work on NVIDIA B200: 1. skip rowwise scaling (does not work yet on B200) 2. add proper values for peak tensor core flops and peak memory bandwidth for B200. This script needs a lot of future improvements to be useful, will do in a stack. Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250225_test.csv ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3c9b1cd ghstack-comment-id: 2683396978 Pull Request resolved: #1778
facebook-github-bot
added
the
CLA Signed
vkuzo
added
the
topic: not user facing
This was referenced Feb 26, 2025
jerryzh168
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Makes the roofline estimation script work on NVIDIA B200:
bandwidth for B200.
This script needs a lot of future improvements to be useful, will do in a stack.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: