-
Notifications
You must be signed in to change notification settings - Fork 257
float8 training: add README.md entry for rowwise scaling #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1733
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 18, 2025
vkuzo
added a commit
that referenced
this pull request
Feb 18, 2025
Summary: This functionality is ready for being exposed in the README, adding the instructions on how to use it via the new recipe API. Test Plan: Ran the newly added code snippet, it works Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: fe08b60dbff4e5a33457b081ceac0af05977b12b ghstack-comment-id: 2667074215 Pull Request resolved: #1733
drisspg
approved these changes
Feb 18, 2025
vkuzo
added a commit
that referenced
this pull request
Feb 19, 2025
Summary: This functionality is ready for being exposed in the README, adding the instructions on how to use it via the new recipe API. Test Plan: Ran the newly added code snippet, it works Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f219bcdfdc0f39003df762dcfda546e55a93394b ghstack-comment-id: 2667074215 Pull Request resolved: #1733
vkuzo
added a commit
that referenced
this pull request
Feb 19, 2025
Summary: This functionality is ready for being exposed in the README, adding the instructions on how to use it via the new recipe API. Test Plan: Ran the newly added code snippet, it works Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 18d97099c787390cc09442e2987b7ff3bba78c9f ghstack-comment-id: 2667074215 Pull Request resolved: #1733
vkuzo
added a commit
that referenced
this pull request
Feb 19, 2025
Summary: This functionality is ready for being exposed in the README, adding the instructions on how to use it via the new recipe API. Test Plan: Ran the newly added code snippet, it works Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 18d97099c787390cc09442e2987b7ff3bba78c9f ghstack-comment-id: 2667074215 Pull Request resolved: #1733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: documentation
Use this tag if this PR adds or improves documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This functionality is ready for being exposed in the README, adding the
instructions on how to use it via the new recipe API.
Test Plan:
Ran the newly added code snippet, it works
Reviewers:
Subscribers:
Tasks:
Tags: