Skip to content

float8 training: add README.md entry for rowwise scaling #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 19, 2025
Merged

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Feb 18, 2025

Summary:

This functionality is ready for being exposed in the README, adding the
instructions on how to use it via the new recipe API.

Test Plan:

Ran the newly added code snippet, it works

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Feb 18, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Feb 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1733

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2025
vkuzo added a commit that referenced this pull request Feb 18, 2025
Summary:

This functionality is ready for being exposed in the README, adding the
instructions on how to use it via the new recipe API.

Test Plan:

Ran the newly added code snippet, it works

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: fe08b60dbff4e5a33457b081ceac0af05977b12b
ghstack-comment-id: 2667074215
Pull Request resolved: #1733
@vkuzo vkuzo added the topic: documentation Use this tag if this PR adds or improves documentation label Feb 18, 2025
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Feb 19, 2025
Summary:

This functionality is ready for being exposed in the README, adding the
instructions on how to use it via the new recipe API.

Test Plan:

Ran the newly added code snippet, it works

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: f219bcdfdc0f39003df762dcfda546e55a93394b
ghstack-comment-id: 2667074215
Pull Request resolved: #1733
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Feb 19, 2025
Summary:

This functionality is ready for being exposed in the README, adding the
instructions on how to use it via the new recipe API.

Test Plan:

Ran the newly added code snippet, it works

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 18d97099c787390cc09442e2987b7ff3bba78c9f
ghstack-comment-id: 2667074215
Pull Request resolved: #1733
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/35/head to main February 19, 2025 03:59
vkuzo added a commit that referenced this pull request Feb 19, 2025
Summary:

This functionality is ready for being exposed in the README, adding the
instructions on how to use it via the new recipe API.

Test Plan:

Ran the newly added code snippet, it works

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 18d97099c787390cc09442e2987b7ff3bba78c9f
ghstack-comment-id: 2667074215
Pull Request resolved: #1733
@vkuzo vkuzo merged commit ed16fe7 into main Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: documentation Use this tag if this PR adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants