Skip to content

Skip calling unwrap_tensor_subclass for torch 2.7+ #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jan 9, 2025

Summary:
att

Test Plan:
python test/integration/test_integration.py -k TestExport

AOTI test also works, but there is some AOT compile issues, reproducible by python test/integration/test_integration.py -k TestAOTI.test_aoti_06, error: https://gist.github.com/jerryzh168/824840130f30ae11bfc1506a7500b931

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:
att

Test Plan:
python test/integration/test_integration.py -k TestExport

AOTI test also works, but there is some AOT compile issues, reproducible by
python test/integration/test_integration.py -k TestAOTI.test_aoti_06

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link

pytorch-bot bot commented Jan 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1531

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 78fae78 with merge base 4738377 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2025
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jan 9, 2025
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jerryzh168 jerryzh168 merged commit 8259a38 into pytorch:main Jan 9, 2025
18 checks passed
desertfire added a commit to pytorch/pytorch that referenced this pull request Jan 10, 2025
Summary: Add _int_mm to the C shim, to resolve a torchao issue, pytorch/ao#1531 (comment)

ghstack-source-id: 3f02a5f
Pull Request resolved: #144571
amdfaa pushed a commit that referenced this pull request Jan 10, 2025
* Skip calling unwrap_tensor_subclass for torch 2.7+

Summary:
att

Test Plan:
python test/integration/test_integration.py -k TestExport

AOTI test also works, but there is some AOT compile issues, reproducible by
python test/integration/test_integration.py -k TestAOTI.test_aoti_06

Reviewers:

Subscribers:

Tasks:

Tags:

* fix
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Jan 13, 2025
Summary: Add _int_mm to the C shim, to resolve a torchao issue, pytorch/ao#1531 (comment)

Differential Revision: [D68030385](https://our.internmc.facebook.com/intern/diff/D68030385)
Pull Request resolved: #144571
Approved by: https://github.com/yushangdi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants