-
Notifications
You must be signed in to change notification settings - Fork 279
Skip calling unwrap_tensor_subclass for torch 2.7+ #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jerryzh168
merged 2 commits into
pytorch:main
from
jerryzh168:remove-unwrap-tensor-subclass
Jan 9, 2025
Merged
Skip calling unwrap_tensor_subclass for torch 2.7+ #1531
jerryzh168
merged 2 commits into
pytorch:main
from
jerryzh168:remove-unwrap-tensor-subclass
Jan 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att Test Plan: python test/integration/test_integration.py -k TestExport AOTI test also works, but there is some AOT compile issues, reproducible by python test/integration/test_integration.py -k TestAOTI.test_aoti_06 Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1531
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 78fae78 with merge base 4738377 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Jan 10, 2025
Summary: Add _int_mm to the C shim, to resolve a torchao issue, pytorch/ao#1531 (comment) ghstack-source-id: 3f02a5f Pull Request resolved: #144571
amdfaa
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Skip calling unwrap_tensor_subclass for torch 2.7+ Summary: att Test Plan: python test/integration/test_integration.py -k TestExport AOTI test also works, but there is some AOT compile issues, reproducible by python test/integration/test_integration.py -k TestAOTI.test_aoti_06 Reviewers: Subscribers: Tasks: Tags: * fix
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jan 13, 2025
Summary: Add _int_mm to the C shim, to resolve a torchao issue, pytorch/ao#1531 (comment) Differential Revision: [D68030385](https://our.internmc.facebook.com/intern/diff/D68030385) Pull Request resolved: #144571 Approved by: https://github.com/yushangdi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
att
Test Plan:
python test/integration/test_integration.py -k TestExport
AOTI test also works, but there is some AOT compile issues, reproducible by python test/integration/test_integration.py -k TestAOTI.test_aoti_06, error: https://gist.github.com/jerryzh168/824840130f30ae11bfc1506a7500b931
Reviewers:
Subscribers:
Tasks:
Tags: