Skip to content

Move files from quantization/prototype -> prototype/quantization #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

Move files from quantization/prototype -> prototype/quantization #1187

merged 2 commits into from
Oct 29, 2024

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Oct 28, 2024 •
edited
Loading

Tasks undertaken:

  • Move files
  • BC breaking

Test Plan : Pass existing tests

Fixes: #1013

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1187

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a39f9f2 with merge base 79ea660 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2024
@facebook-github-bot
Copy link
Contributor

@jainapurva has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jainapurva jainapurva marked this pull request as ready for review October 29, 2024 16:16
@facebook-github-bot
Copy link
Contributor

@jainapurva has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

andrewor14
andrewor14 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@andrewor14 andrewor14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

torchao/quantization/prototype/mixed_precision/scripts/naive_intNwo.py Outdated
except Exception as e:
raise

from torchao.prototype.quantization.mixed_precision.scripts.naive_intNwo import intN_weight_only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't find any usages of this, I think it may be OK to straight up break BC (i.e. delete this file). I don't think there are any users currently, but please check ghimport as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Currently, this file isn't used anywhere, will remove it.

@facebook-github-bot
Copy link
Contributor

@jainapurva has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jainapurva jainapurva added the topic: bc-breaking Use this tag if this PR breaks backward compatibility label Oct 29, 2024
@jainapurva jainapurva merged commit 958a197 into main Oct 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bc-breaking Use this tag if this PR breaks backward compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ensure that there is only one "prototype" folder in torchao
4 participants
@jainapurva @facebook-github-bot @andrewor14 @jerryzh168