Skip to content

Revert "[ROCm] use dataclass for fnuz type setting" #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Revert "[ROCm] use dataclass for fnuz type setting" #1148

merged 1 commit into from
Oct 23, 2024

Conversation

msaroufim
Copy link
Member

Reverts #1142

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1148

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures

As of commit 4d4a9fd with merge base eb1fb3a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 23, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@msaroufim msaroufim merged commit d252612 into main Oct 23, 2024
5 of 14 checks passed
@msaroufim msaroufim deleted the revert-1142-fnuz_config branch October 23, 2024 15:07
jeffdaily added a commit to jeffdaily/ao that referenced this pull request Oct 23, 2024
@jeffdaily
Revert "Revert "[ROCm] use dataclass for fnuz type setting" (pytorch#…
b21d60a 
…1148)"

This reverts commit d252612.
@jeffdaily jeffdaily mentioned this pull request Oct 23, 2024
Merged
@msaroufim msaroufim mentioned this pull request Oct 23, 2024
Closed
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
@kwen2501 @Jack-Khuu
[Distributed] Accept model name (pytorch#1148)
7a4f0d1 
Co-authored-by: Jack-Khuu <jack.khuu.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msaroufim @facebook-github-bot