Fix some conversion issues on the corner cases for transformer based …#4080
Open
wenbingl wants to merge 1 commit intopytorch:mainfrom
Open
Fix some conversion issues on the corner cases for transformer based …#4080wenbingl wants to merge 1 commit intopytorch:mainfrom
wenbingl wants to merge 1 commit intopytorch:mainfrom
Conversation
narendasan
reviewed
Feb 12, 2026
| try: | ||
| max_val = int(var_range.upper) | ||
| except (TypeError, AttributeError, ValueError, OverflowError): | ||
| max_val = 2**31 - 1 |
Collaborator
There was a problem hiding this comment.
Do you know what the TRT max dimension size is?
I think theres a cleaner way to do this, but theres some additional changes needed.
In general I think in the inf case we should have some sane default
cc: @zewenli98
Contributor
Author
There was a problem hiding this comment.
Feel free to proposed some more systematic fixing, I can only do a simple ad-hoc fix to demo the issues.
RE: Do you know what the TRT max dimension size is?
TensorRT dim data type is int64_t, but when I tried to int64 maximum value, it seems incompatible with pyTorch and raise some exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some conversion issues on the corner cases for transformer based ASR model.
Verified the issue gone after apply the changes in PR.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: