Skip to content

Resource partitioner CI fix #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cehongwang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resource partitioner CI fix #4005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/py/dynamo/partitioning/test_000_resource_partitioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import psutil
import torch
import torch.nn as nn
from torch.fx.passes.splitter_base import Subgraph
Expand Down Expand Up @@ -79,7 +80,8 @@ def forward(self, x):
partitioner = ResourcePartitioner(
submodule,
submodule_name=name,
cpu_memory_budget=2 * 1024 * 1024 * 1024,
cpu_memory_budget=0.89 * 1024 * 1024 * 1024
+ psutil.Process().memory_info().rss, # 0.89GB + current memory usage
)
subgraphs = partitioner.put_nodes_into_subgraphs()
new_subgraphs = []
Expand Down
17 changes: 13 additions & 4 deletions tests/py/dynamo/partitioning/test_001_resource_partitioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from typing import Any, List

import psutil
import torch
import torch.nn as nn
import torch.nn.functional as F
Expand Down Expand Up @@ -84,7 +85,9 @@ def forward(self, x):
)

partitioned_module = resource_partition(
partitioned_module, cpu_memory_budget=2 * 1024 * 1024 * 1024 # 2GB,
partitioned_module,
cpu_memory_budget=0.89 * 1024 * 1024 * 1024
+ psutil.Process().memory_info().rss, # 0.89GB + current memory usage,
)

self.assertEqual(
Expand Down Expand Up @@ -166,7 +169,9 @@ def forward(self, x):
)

partitioned_module = resource_partition(
partitioned_module, cpu_memory_budget=1.4 * 1024 * 1024 * 1024 # 1.4GB,
partitioned_module,
cpu_memory_budget=0.39 * 1024 * 1024 * 1024
+ psutil.Process().memory_info().rss, # 0.39GB + current memory usage,
)

assert (
Expand Down Expand Up @@ -298,7 +303,9 @@ def forward(self, x):
)

partitioned_module = resource_partition(
partitioned_module, cpu_memory_budget=1.4 * 1024 * 1024 * 1024 # 1.4GB,
partitioned_module,
cpu_memory_budget=0.39 * 1024 * 1024 * 1024
+ psutil.Process().memory_info().rss, # 0.39GB + current memory usage,
)

assert (
Expand Down Expand Up @@ -396,7 +403,9 @@ def forward(self, x):
)

partitioned_module = resource_partition(
partitioned_module, cpu_memory_budget=1.4 * 1024 * 1024 * 1024 # 1.4GB,
partitioned_module,
cpu_memory_budget=0.39 * 1024 * 1024 * 1024
+ psutil.Process().memory_info().rss, # 0.39GB + current memory usage,
)

assert (
Expand Down
Loading